the task #2 from HW #2 was completed - #3
Open
Dmitriy-Klv wants to merge 3 commits into
Open
Conversation
samodurOFF
requested changes
Apr 26, 2026
| from pydantic import BaseModel, EmailStr, Field, model_validator | ||
|
|
||
| class Address(BaseModel): | ||
| city: str = Field(..., min_length=2) |
Owner
There was a problem hiding this comment.
С версии 2.0 в pydantic не нужно указывать ... для обозначения обязательного поля, о чем я говорил на занятии.
Suggested change
| city: str = Field(..., min_length=2) | |
| city: str = Field(min_length=2) |
Comment on lines
+18
to
+19
| if self.is_employed: | ||
| if not (18 <= self.age <= 65): |
Owner
There was a problem hiding this comment.
Лучше перечислить эти условия через and
Suggested change
| if self.is_employed: | |
| if not (18 <= self.age <= 65): | |
| if self.is_employed and not (18 <= self.age <= 65): |
| user = User.model_validate_json(json_str) | ||
| return user.model_dump_json(indent=4) | ||
| except pydantic.ValidationError as e: | ||
| return f"Validation error: {e.json()}" |
Owner
There was a problem hiding this comment.
Не очень хорошо, когда функция возвращает различные структуры данных.
Suggested change
| return f"Validation error: {e.json()}" | |
| return e.json() |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.